feat/independent loggers for components - #204
Merged
Merged
Conversation
…le and class. Added unit tests to verify the change in all the places that currently log information
achilleas-kal
approved these changes
May 18, 2023
added 2 commits
May 18, 2023 22:34
…tion for the next release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the logging logic in the SDK to use independent loggers for each module and class.
The logic to correctly get the loggers was implemented in the class
LoggerProviderto have it in a single place.All places where the SDK was logging were updated to use the new
LoggerProvider.The PR includes unit tests to validate the logs format. For that the package
testswas created.There are two new development dependencies added to support the implementation and execution of the unit tests:
The new dependencies were added as dev dependencies to not require them when the SDK is installed as a package.
Created a new package called
utilsto start moving all utility modules there. Right now theutilsmodule has been moved there. The newloggermodule has been created in there too.